fix: correct typos in error messages and guard empty coordinate extraction - #300
Open
fix2015 wants to merge 1 commit into
Open
fix: correct typos in error messages and guard empty coordinate extraction#300fix2015 wants to merge 1 commit into
fix2015 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
"on of"→"one of"in two error messages inppadb_agent_os.py(lines 439, 450)extract_click_coordinates()inanthropic/utils.pyto raise a clearValueErrorinstead ofIndexErrorwhen no coordinates are found in the LLM responseChanges
src/askui/tools/android/ppadb_agent_os.py"did you call on of the set_device methods?"→"did you call one of the set_device methods?""did you call on of the set_display methods?"→"did you call one of the set_display methods?"src/askui/models/anthropic/utils.pyre.findall()returns no matches, raiseValueErrorwith descriptive message instead of crashing withIndexErroronmatches[-1]Test plan
ValueErrorwith a helpful message when no coordinates are found